Print all requests to console in debug mode #4365
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
previously approved these changes
Dec 17, 2024
|
Good idea! |
|
Changed the approach to log on all requests, and print out the url's relative path. For example, output looks like: |
mats-stripe
previously approved these changes
Dec 18, 2024
wooj-stripe
changed the title
I believe uses can log into their dashboard and access request logs based on requestID, but the idea is if they open an issue w/ us and include requests, we'd have more info on figuring out what's going on. |
davidme-stripe
previously approved these changes
Dec 18, 2024
davidme-stripe
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's kind of difficult to see when requests are failing. I propose we print requestID to the console so that it's easier to see/debug.
Motivation
Difficult to view requestId's unless you have a ton of breakpoints in code.
Testing
Manual testing.
Changelog